New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong test in left join condition #9188

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
4 participants
@jocel1
Contributor

jocel1 commented Jun 14, 2018

Questions Answers
Branch? 1.7.4.x
Description? If a translation is missing, the query will return all the product instead of the one corresponding to the wanted id_product
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? Create two product without any corresponding entry in product_lang and try to display it

This change is Reviewable

@jocel1 jocel1 requested a review from PierreRambaud Jun 14, 2018

@jocel1 jocel1 added this to the 1.7.4.0 milestone Jun 14, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Jun 15, 2018

@eternoendless eternoendless changed the title from fix wrong test in left join condition to Fix wrong test in left join condition Jun 15, 2018

@eternoendless

This comment has been minimized.

Member

eternoendless commented Jun 15, 2018

Thank you @jocel1

@eternoendless eternoendless merged commit 28a0118 into PrestaShop:1.7.4.x Jun 15, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment