New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Payment methods page #9192

Merged
merged 11 commits into from Jun 21, 2018

Conversation

Projects
None yet
7 participants
@sarjon
Member

sarjon commented Jun 15, 2018

Questions Answers
Branch? develop
Description? Migrates 'Improve > Payment > Payment Methods' page to Symfony
Type? new feature
Category? BO
BC breaks? yes (overrides)
Deprecations? no
Fixed ticket? n/a
How to test? New page should work the same as old one.

This change is Reviewable

*
* @return ModuleInterface[]
*/
protected function getPaymentModulesToDisplay($legacyController)

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Jun 15, 2018

Contributor

to be extracted in its own service 👍

This comment has been minimized.

@sarjon

sarjon Jun 17, 2018

Member

any suggestions were it should go? 🤔

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Jun 18, 2018

Contributor

in PrestaShop\PrestaShop\Adapter\Module\Presenter\PaymentModulesPresenter with only one method: present() with no arguments, you can declare "legacyController" as constant for exemple.

{% else %}
<div class="alert alert-warning" role="alert">
<p class="alert-text">
{{ 'It seems there are no recommended payment solutions for your country.'|trans }} <br>

This comment has been minimized.

@LouiseBonnard

LouiseBonnard Jun 15, 2018

Contributor

Is this an error message?

This comment has been minimized.

@sarjon

sarjon Jun 17, 2018

Member

It's more like notification/warning. But not an error.

This comment has been minimized.

@LouiseBonnard

LouiseBonnard Jun 18, 2018

Contributor

If it's not a tooltip, I would say Admin.Payment.Notification then!

<div class="alert alert-warning" role="alert">
<p class="alert-text">
{{ 'It seems there are no recommended payment solutions for your country.'|trans }} <br>
<a class="_blank" href="https://www.prestashop.com/en/contact-us">{{ 'Do you think there should be one? Let us know!'|trans }}</a>

This comment has been minimized.

@LouiseBonnard

LouiseBonnard Jun 15, 2018

Contributor

It is currently in both Admin.Shipping.Feature and messages files.

This comment has been minimized.

@sarjon

sarjon Jun 17, 2018

Member

should it keep Admin.Shipping.Feature domain?

This comment has been minimized.

@LouiseBonnard

LouiseBonnard Jun 18, 2018

Contributor

I think so... what do you think @Quetzacoalt91 ?

@sarjon sarjon changed the title from [WIP] Migrate Payment methods page to Migrate Payment methods page Jun 19, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 19, 2018

Now we have the new routing, you need to update your pull request 👍

I'll document this asap, thanks @sarjon !

@sarjon

This comment has been minimized.

Member

sarjon commented Jun 19, 2018

@mickaelandrieu rebased and ready for review/QA!

@marionf marionf self-assigned this Jun 21, 2018

@PierreRambaud

👍

@marionf marionf removed the waiting for QA label Jun 21, 2018

@marionf marionf removed their assignment Jun 21, 2018

@mickaelandrieu mickaelandrieu merged commit 13c322a into PrestaShop:develop Jun 21, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 21, 2018

Thanks @sarjon !

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Jun 21, 2018

@mickaelandrieu mickaelandrieu referenced this pull request Jun 26, 2018

Closed

Roadmap migration (1.7.5) #10

26 of 40 tasks complete

@mickaelandrieu mickaelandrieu referenced this pull request Sep 5, 2018

Closed

Symfony migration roadmap for 1.7.5 #10301

27 of 40 tasks complete

@matks matks added the migration label Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment