New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mixed up display in some cases at partial refunds #9195

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
4 participants
@paeddl
Contributor

paeddl commented Jun 18, 2018

Questions Answers
Branch? develop
Description? Fixes a bug in display at the orders-view when creating a partial refund
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no

This change is Reviewable

@prestonBot prestonBot added the develop label Jun 18, 2018

@mickaelandrieu mickaelandrieu added the Bug label Jun 21, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 21, 2018

Hello @paeddl, can you describe how a member from QA team can validate this contribution please?

@mickaelandrieu mickaelandrieu changed the title from BO: Fixed mixed up display in some cases at partial refunds to Fixed mixed up display in some cases at partial refunds Jun 21, 2018

@paeddl

This comment has been minimized.

Contributor

paeddl commented Jun 21, 2018

@mickaelandrieu

  • Create an order with for example a bundled product.
  • Click on "partial refund" for this order
  • Then you'll see a misaligned view like attached in the screenshot
    bildschirmfoto 2018-06-21 um 11 46 19

@marionf marionf self-assigned this Jun 21, 2018

@marionf

This comment has been minimized.

Contributor

marionf commented Jun 21, 2018

Hello @paeddl

I can't reproduce your issue
From 1200 to 1855px I have this:

1855 a 1200px

Under 1200px I have this:
moins 1200px

Can you tell me with which browser and which size of screen you have this issue ?

Thanks :)

@paeddl

This comment has been minimized.

Contributor

paeddl commented Jun 21, 2018

Hello @marionf
I just tried locally and on a customers installation, it starts at a width of 1200px, and then it's always there, even if the window gets bigger. Browsers: Firefox and Chrome in latest versions.

@marionf

This comment has been minimized.

Contributor

marionf commented Jun 21, 2018

All right, thank you @paeddl

@marionf marionf removed their assignment Jun 21, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 21, 2018

and merged! Thanks @paeddl

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Jun 21, 2018

@mickaelandrieu mickaelandrieu merged commit 2c0ea82 into PrestaShop:develop Jun 21, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment