New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve form choice providers #9205

Merged
merged 2 commits into from Jun 25, 2018

Conversation

Projects
None yet
4 participants
@sarjon
Member

sarjon commented Jun 21, 2018

Questions Answers
Branch? develop
Description? This PR updates naming of form choice providers and moves them to the same namespace.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Localization & Geolocation pages should not break, as they are the only ones that uses form choice providers at the moment.

This change is Reviewable

@prestonBot prestonBot added the develop label Jun 21, 2018

@sarjon

This comment has been minimized.

Member

sarjon commented Jun 21, 2018

@mickaelandrieu maybe these form choice providers should be documented somewhere as they can be reused a lot?

* @param CountryDataProvider $countryDataProvider
*/
public function __construct(
LegacyContext $legacyContext,
$langId,

This comment has been minimized.

@mickaelandrieu
@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 21, 2018

@sarjon you're right, but we need to think about a common use case a PrestaShop developer could have to make it a cookbook in docs: do you have something in mind?

@sarjon

This comment has been minimized.

Member

sarjon commented Jun 22, 2018

what do you mean by 'common use case'?

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 22, 2018

Some tasks where PrestaShop developers must use form choice provider

@sarjon

This comment has been minimized.

Member

sarjon commented Jun 23, 2018

i think this will be most useful when module developers will be able to create modern controllers and use choice providers it in their forms.

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Jun 25, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Jun 25, 2018

@mickaelandrieu mickaelandrieu merged commit 91cba35 into PrestaShop:develop Jun 25, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 25, 2018

Thanks @sarjon and @ntiepresta for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment