New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "Configure > Advanced Parameters > Database > SQL Manager" page #9206

Merged
merged 67 commits into from Aug 16, 2018

Conversation

Projects
None yet
8 participants
@sarjon
Member

sarjon commented Jun 22, 2018

Questions Answers
Branch? develop
Description? Migrates SQL Manager page to Symfony.
Type? improvement
Category? BO
BC breaks? yes (overrides)
Deprecations? no
Fixed ticket? n/a
How to test? Page should work the same as old one.

This change is Reviewable

*
* @return array
*/
public function getTables()

This comment has been minimized.

@sarjon

sarjon Jun 22, 2018

Member

maybe for this method and couple others in this class, instead of adding adapter i should move it to RequestSqlRepository?

@sarjon

sarjon Jun 22, 2018

Member

maybe for this method and couple others in this class, instead of adding adapter i should move it to RequestSqlRepository?

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Jul 4, 2018

Contributor

test it, we're still looking for some AbstractRepository implementation :)

@mickaelandrieu

mickaelandrieu Jul 4, 2018

Contributor

test it, we're still looking for some AbstractRepository implementation :)

@mickaelandrieu mickaelandrieu referenced this pull request Jun 26, 2018

Closed

Roadmap migration (1.7.5) #10

26 of 40 tasks complete
@mickaelandrieu

Some minor improvements already

@mickaelandrieu mickaelandrieu added the wip label Jul 4, 2018

@sarjon sarjon changed the title from [WIP] Migrate "Configure > Advanced Parameters > Database > SQL Manager" page to Migrate "Configure > Advanced Parameters > Database > SQL Manager" page Jul 10, 2018

@sarjon

This comment has been minimized.

Show comment
Hide comment
@sarjon

sarjon Jul 13, 2018

Member

@mickaelandrieu is anything else needed for this PR before QA review?

Member

sarjon commented Jul 13, 2018

@mickaelandrieu is anything else needed for this PR before QA review?

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Jul 13, 2018

Contributor

ping @PierreRambaud your call :)

Contributor

mickaelandrieu commented Jul 13, 2018

ping @PierreRambaud your call :)

@sarjon

This comment has been minimized.

Show comment
Hide comment
@sarjon

sarjon Aug 13, 2018

Member

hey @marionf PR is now up to date.

Regarding your comment:

When I click on "Show SQL query" I have not the same query as before

SQL has changed slightly, you can read comments above about it. :)

Member

sarjon commented Aug 13, 2018

hey @marionf PR is now up to date.

Regarding your comment:

When I click on "Show SQL query" I have not the same query as before

SQL has changed slightly, you can read comments above about it. :)

@marionf marionf assigned marionf and unassigned marionf Aug 16, 2018

@marionf marionf added the QA ✔️ label Aug 16, 2018

@mickaelandrieu mickaelandrieu merged commit 7231056 into PrestaShop:develop Aug 16, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 16, 2018

Contributor

Thanks @sarjon !

Contributor

mickaelandrieu commented Aug 16, 2018

Thanks @sarjon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment