New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix products pagination without URL rewriting #9214

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Jun 25, 2018

Questions Answers
Branch? develop
Description? On the front-office of a shop without URL rewriting, switching to another page of the same category does not work because of canonical URL issues.
Type? bug fix
Category? FO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4847
How to test? Using the pagination without URL rewriting must work .

capture du 2018-06-25 15-19-29


This change is Reviewable

@prestonBot prestonBot added the develop label Jun 25, 2018

@@ -1746,8 +1746,6 @@ protected function updateQueryString(array $extraParams = null)
}
}
ksort($params);

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Jun 25, 2018

Contributor

ok but... why this function was here at first place? I'm afraid someone in 1 year will re-introduce it for the same reason, don't you think?

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Jun 25, 2018

Member

I don't understand why it was here at the first place. Our canonical URLs are not generated with their parameters sorted alphabetically.

If we want to regenerate an URL and comparing it with the default canonical URL, we have to reuse them in the same order as they are in the current address.

@mickaelandrieu mickaelandrieu added the Bug label Jun 25, 2018

@marionf marionf self-assigned this Jun 26, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Jun 26, 2018

@marionf marionf removed their assignment Jun 26, 2018

@marionf marionf added this to the 1.7.5.0 milestone Jun 26, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 26, 2018

LGTM

Thanks @Quetzacoalt91 and @marionf for review

@mickaelandrieu mickaelandrieu merged commit b607cdb into PrestaShop:develop Jun 26, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:fix-product-pagination branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment