New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapted module URLs for new routing #9215

Merged
merged 3 commits into from Jun 26, 2018

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Jun 25, 2018

Questions Answers
Branch? develop
Description? @marionf reported the module page wasn't working anymore after the new routing. The PRs updates the URLs remaining on the old address.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Reach the module page

This change is Reviewable

@prestonBot prestonBot added the develop label Jun 25, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Jun 25, 2018

This PR is not done, I will add another commit to use the Symfony router instead of hardcoding URLs.

@Quetzacoalt91 Quetzacoalt91 removed the wip label Jun 25, 2018

@Quetzacoalt91 Quetzacoalt91 changed the title from [WIP] Adapted URLs for new routing to Adapted URLs for new routing Jun 25, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Jun 25, 2018

Ready for review!

@Quetzacoalt91 Quetzacoalt91 changed the title from Adapted URLs for new routing to Adapted module URLs for new routing Jun 25, 2018

{{ parent() }}
<script>
var moduleURLs = {
'catalogRefresh': '{{ url('admin_module_catalog_refresh')|e('js') }}',

This comment has been minimized.

@PierreRambaud

PierreRambaud Jun 26, 2018

Contributor

Maybe use path instead of url, absolute link is useful only when using cross-domain ajax or generating emails, because the hostname won't be the same.

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Jun 26, 2018

Member

Here you go

@hadrich-hatem hadrich-hatem referenced this pull request Jun 26, 2018

Merged

Click on read more #8941

@marionf marionf self-assigned this Jun 26, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Jun 26, 2018

@marionf marionf removed their assignment Jun 26, 2018

@marionf marionf added this to the 1.7.5.0 milestone Jun 26, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 71d0af3 into PrestaShop:develop Jun 26, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:url-1740-modules branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment