New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cookie encryption #9218

Merged
merged 7 commits into from Jun 26, 2018

Conversation

Projects
None yet
3 participants
@PierreRambaud
Contributor

PierreRambaud commented Jun 26, 2018

Questions Answers
Branch? 1.6.1.x
Description? Improve cookie encryption, remove Blowfish.
Type? improvement
Category? BO
BC breaks? yes
Deprecations? yes
How to test? Try to connect & navigate, only cookies are affected.

This change is Reviewable

PierreRambaud added some commits Jun 18, 2018

Add signature to encrypted cookie
Use Encrypt-to-MAC, and MAC-to-Decrypt when using mcrypt_* functions
in secure cookies.

@prestonBot prestonBot added the 1.6.1.x label Jun 26, 2018

@eternoendless eternoendless added this to the 1.6.1.20 milestone Jun 26, 2018

@eternoendless

This comment has been minimized.

Member

eternoendless commented Jun 26, 2018

Thank you @PierreRambaud

@eternoendless eternoendless merged commit 3db8f82 into PrestaShop:1.6.1.x Jun 26, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:improve-mcrypt-mac branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment