New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL field is only available is accessed using HTTPS protocol #9223

Merged
merged 1 commit into from Jun 27, 2018

Conversation

Projects
None yet
4 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Jun 27, 2018

Questions Answers
Branch? 1.7.4.x
Description? The SSL field was rendered even when we don't want to.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? ping @PierreRambaud :-)

Important guidelines


This change is Reviewable

@prestonBot prestonBot added the 1.7.4.x label Jun 27, 2018

@mickaelandrieu mickaelandrieu added the Bug label Jun 27, 2018

@mickaelandrieu mickaelandrieu added this to the 1.7.4.0 milestone Jun 27, 2018

@mickaelandrieu mickaelandrieu merged commit fa240ff into PrestaShop:1.7.4.x Jun 27, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:make-preferences-form-dependent-of-request branch Jun 27, 2018

@mortenhartvig

This comment has been minimized.

mortenhartvig commented Jul 2, 2018

You forget, that the page may be served by a proxy in between. E.g. cloudflare or nginx/apache reverse proxy having ssl termination. I guess that you have to check this forwarding in the headers. Else next version will break for those users.

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jul 2, 2018

if you use a proxy, you need to register it in the PrestaShop configuration. Take a look at Symfony framework configuration if you need to do it :)

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jul 2, 2018

@mortenhartvig I will have a try on tomorrow if you want, but it's just a apache / nginx configuration logically.

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jul 3, 2018

@mortenhartvig @mickaelandrieu I confirm that I don't have any problem when running Prestashop with apache / nginx reverse proxy and ssl (configured on apache & nginx).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment