New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined property key on Rijndael #9224

Merged
merged 1 commit into from Jun 27, 2018

Conversation

Projects
None yet
6 participants
@PierreRambaud
Contributor

PierreRambaud commented Jun 27, 2018

Questions Answers
Branch? 1.6.1.x
Description? Undefined property key
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-9992 http://forge.prestashop.com/browse/PSCSX-9993 http://forge.prestashop.com/browse/PSCSX-9994 http://forge.prestashop.com/browse/PSCSX-9995 http://forge.prestashop.com/browse/PSCSX-9996
How to test? Follow issues

This change is Reviewable

@prestonBot prestonBot added the 1.6.1.x label Jun 27, 2018

@PierreRambaud PierreRambaud requested a review from eternoendless Jun 27, 2018

@eternoendless eternoendless changed the title from Fix undefined property key on Rijnadeal to Fix undefined property key on Rijndael Jun 27, 2018

@eternoendless eternoendless added this to the 1.6.1.20 milestone Jun 27, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Jun 27, 2018

@PierreRambaud PierreRambaud merged commit 74207b2 into PrestaShop:1.6.1.x Jun 27, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix-undefined-property branch Jun 27, 2018

@studiox3

This comment has been minimized.

studiox3 commented on classes/Rijndael.php in b07763d Jul 23, 2018

Warning
Use of undefined constant MCRYPT_RIJNDAEL_128 - assumed 'MCRYPT_RIJNDAEL_128' (this will throw an Error in a future version of PHP) in ../classes/Rijndael.php on line 124

Server software version: nginx/1.14.0
PHP versija 7.2.7
Memory limit: 128M
Max execution time: 30
MySQL version: 5.7.22

This comment has been minimized.

Contributor

PierreRambaud replied Jul 23, 2018

There's a Waiting PR : #9251, you can apply the patch if you don't want to wait.

@hakeryk2

This comment has been minimized.

hakeryk2 commented Oct 10, 2018

There's a Waiting PR : #9251, you can apply the patch if you don't want to wait.

Your solution is bad because it creates security flaws - this one is good https://github.com/PrestaShop/PrestaShop/pull/8256/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment