New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alt tag for images categories #9227

Merged
merged 2 commits into from Jun 28, 2018

Conversation

Projects
None yet
3 participants
@marionf
Contributor

marionf commented Jun 27, 2018

Questions Answers
Branch? 1.7.4.x
Description? Add the alt tag for the image categories
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4413
How to test? Look if the images of categories contain a alt tag

Important guidelines


This change is Reviewable

@@ -32,7 +32,7 @@
{/if}
{if $category.image.large.url}
<div class="category-cover">
<img src="{$category.image.large.url}" alt="{$category.image.legend}">
<img src="{$category.image.large.url}" alt="{$category.name}">

This comment has been minimized.

@PierreRambaud

PierreRambaud Jun 27, 2018

Contributor

Should it be like that in case there is a legend?:

<img src="{$category.image.large.url}" alt="{if !empty($category.image.legend)}{$category.image.legend}{else}{$category.name}{/if}">

@marionf marionf added the QA ✔️ label Jun 28, 2018

@PierreRambaud PierreRambaud merged commit ce62b49 into 1.7.4.x Jun 28, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the boom-4413 branch Jun 28, 2018

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jun 28, 2018

Thanks @marionf

@PierreRambaud PierreRambaud modified the milestones: 1.7.4.1, 1.7.4.0 Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment