New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate module positions #9228

Merged
merged 56 commits into from Aug 24, 2018

Conversation

Projects
None yet
6 participants
@PierreRambaud
Contributor

PierreRambaud commented Jun 28, 2018

Questions Answers
Branch? develop
Description? Migrate module position to new system
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket ? Fixes #10186
How to test? Move hooks positions, use arrows and search engine. You can compare interface with /admin-dev/index.php?controller=AdminModulesPositions. There're some change in the interface (remove useless buttons, fix bugs, etc).

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Jul 16, 2018

Contributor

Hello @PierreRambaud, maybe a rebase and build of assets? do you have a deadline to finish this? Maybe before Thursday? 🙏

Contributor

mickaelandrieu commented Jul 16, 2018

Hello @PierreRambaud, maybe a rebase and build of assets? do you have a deadline to finish this? Maybe before Thursday? 🙏

I need to review this, I don't remember at all :)

PierreRambaud added some commits Aug 16, 2018

@marionf marionf removed their assignment Aug 23, 2018

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 23, 2018

Contributor

@marionf Should be better now, nice catch and sorry for the delay.

Contributor

PierreRambaud commented Aug 23, 2018

@marionf Should be better now, nice catch and sorry for the delay.

@marionf marionf self-assigned this Aug 23, 2018

PierreRambaud added some commits Aug 23, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Aug 24, 2018

Contributor

@PierreRambaud

If I click on edit or transplant a module and save, I have an invalid token message. If I click on "Yes, I understand the risk", I am well redirected to the migrated page but without any success message.

Contributor

marionf commented Aug 24, 2018

@PierreRambaud

If I click on edit or transplant a module and save, I have an invalid token message. If I click on "Yes, I understand the risk", I am well redirected to the migrated page but without any success message.

@marionf marionf removed their assignment Aug 24, 2018

@marionf marionf added the QA ✔️ label Aug 24, 2018

@mickaelandrieu mickaelandrieu merged commit 8a37ae6 into PrestaShop:develop Aug 24, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 24, 2018

Contributor

Good job @PierreRambaud and thanks for the review @marionf

Contributor

mickaelandrieu commented Aug 24, 2018

Good job @PierreRambaud and thanks for the review @marionf

@PierreRambaud PierreRambaud deleted the PierreRambaud:improvement/modules-positions branch Aug 27, 2018

@mickaelandrieu mickaelandrieu referenced this pull request Sep 5, 2018

Open

Symfony migration roadmap for 1.7.5 #10301

27 of 40 tasks complete

@matks matks added the migration label Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment