New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add themes in gitignore (except classic) #9247

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Jul 2, 2018

Questions Answers
Branch? develop
Description? Avoid other themes than classic to be show in "to be committed` files.
Type? improvement
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Add a personal theme, and checks it does not appear when you execute git status. Core element must still appear when modified.

This change is Reviewable

@prestonBot prestonBot added the develop label Jul 2, 2018

@Quetzacoalt91 Quetzacoalt91 changed the title from Ignore non-native themes to be included to Ignore non-native themes to be included in `git status` Aug 23, 2018

@Quetzacoalt91 Quetzacoalt91 changed the title from Ignore non-native themes to be included in `git status` to Add themes in gitignore (except classic) Oct 3, 2018

@matks matks reopened this Oct 3, 2018

@matks

matks approved these changes Oct 3, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit c15c03c into PrestaShop:develop Oct 3, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:gitignore-themes branch Oct 3, 2018

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment