New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create, edit and delete Linkwidget #9275

Merged
merged 2 commits into from Sep 13, 2018

Conversation

Projects
None yet
7 participants
@fouratachour
Contributor

fouratachour commented Jul 6, 2018

Questions Answers
Branch? develop
Description? Create, edit and delete a different LinkWidget HOOK
Type? new feature
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? TEST_PATH=full/15_design/3_link_widget npm run specific-test -- --URL=FrontOfficeURL

This change is Reviewable

@fouratachour fouratachour changed the title from Linkwidget to Create, edit and delete Linkwidget Jul 16, 2018

@kpodemski

This comment has been minimized.

Show comment
Hide comment
@kpodemski

kpodemski Jul 27, 2018

Contributor

I wonder if we should have e2e tests for native modules inside core repo, shouldn't be this available directly from module repo? cc @mickaelandrieu @Quetzacoalt91 @eternoendless

Contributor

kpodemski commented Jul 27, 2018

I wonder if we should have e2e tests for native modules inside core repo, shouldn't be this available directly from module repo? cc @mickaelandrieu @Quetzacoalt91 @eternoendless

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Jul 30, 2018

Contributor

@kpodemski Totally agreed, we are trying to find a way to add functional, unit and e2e tests directly in modules.

Contributor

PierreRambaud commented Jul 30, 2018

@kpodemski Totally agreed, we are trying to find a way to add functional, unit and e2e tests directly in modules.

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Jul 30, 2018

Member

shouldn't be this available directly from module repo?

@kpodemski It makes absolute sense to me! But I don't think it will be easy.
cc @mbadrani

Member

eternoendless commented Jul 30, 2018

shouldn't be this available directly from module repo?

@kpodemski It makes absolute sense to me! But I don't think it will be easy.
cc @mbadrani

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Jul 30, 2018

Contributor

As @toutantic said, we need to focus and show to everyone how they can implement and execute E2E tests. Maybe use a generic npm dependencies (created by us) to install, configure and run a prestashop instance as we do in test/E2E and use path env vars to select module. (THis one will be changed to TEST_PATH in the future due to errors why zsh)

Contributor

PierreRambaud commented Jul 30, 2018

As @toutantic said, we need to focus and show to everyone how they can implement and execute E2E tests. Maybe use a generic npm dependencies (created by us) to install, configure and run a prestashop instance as we do in test/E2E and use path env vars to select module. (THis one will be changed to TEST_PATH in the future due to errors why zsh)

@fatmaBouchekoua

This comment has been minimized.

Show comment
Hide comment
@fatmaBouchekoua

fatmaBouchekoua Sep 13, 2018

Contributor

@mbadrani this PR is ready to be merged

Contributor

fatmaBouchekoua commented Sep 13, 2018

@mbadrani this PR is ready to be merged

@mbadrani

This comment has been minimized.

Show comment
Hide comment
@mbadrani

mbadrani Sep 13, 2018

Contributor

@fatmaBouchekoua some conflicts here

Contributor

mbadrani commented Sep 13, 2018

@fatmaBouchekoua some conflicts here

@mbadrani

This comment has been minimized.

Show comment
Hide comment
@mbadrani

mbadrani Sep 13, 2018

Contributor

@fatmaBouchekoua there are some conflicts here

Contributor

mbadrani commented Sep 13, 2018

@fatmaBouchekoua there are some conflicts here

@fouratachour

This comment has been minimized.

Show comment
Hide comment
@fouratachour

fouratachour Sep 13, 2018

Contributor

@mbadrani @fatmaBouchekoua : conflicts resolved !

Contributor

fouratachour commented Sep 13, 2018

@mbadrani @fatmaBouchekoua : conflicts resolved !

@mbadrani mbadrani merged commit 7b9e5a1 into PrestaShop:develop Sep 13, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud added the TE label Oct 19, 2018

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment