New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull-request template with additional PR types #9292

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
5 participants
@sarjon
Member

sarjon commented Jul 9, 2018

Questions Answers
Branch? develop
Description? It adds additional "refacto" & "critical" so everyone could know that these exist.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? n/a

This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Jul 9, 2018

Collaborator

Hi!

Your pull request description seems to be incomplete or malformed:

  • The type should be one of: new feature, improvement, bug fix, refacto or critical.

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

Collaborator

prestonBot commented Jul 9, 2018

Hi!

Your pull request description seems to be incomplete or malformed:

  • The type should be one of: new feature, improvement, bug fix, refacto or critical.

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@prestonBot prestonBot added the develop label Jul 9, 2018

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Jul 9, 2018

Contributor

We need to update PrestonBot before =)

Contributor

PierreRambaud commented Jul 9, 2018

We need to update PrestonBot before =)

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Jul 9, 2018

Contributor

We need to update PrestonBot before =)

Preston was broken recently, but it was able to recognize refacto and critical types, with already a specific label for critical. For refacto, this needs to be discussed with @ttoine and @marionf afaik.

But before introduce new features, I'd like to see "him" working again for the basics 👍

Contributor

mickaelandrieu commented Jul 9, 2018

We need to update PrestonBot before =)

Preston was broken recently, but it was able to recognize refacto and critical types, with already a specific label for critical. For refacto, this needs to be discussed with @ttoine and @marionf afaik.

But before introduce new features, I'd like to see "him" working again for the basics 👍

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Jul 10, 2018

Contributor

@mickaelandrieu Look like something is weird with preston when it was working yesterday -_-
Preston already has critical and refacto in its valid types and we can already add these types while creating a PR :/

Contributor

PierreRambaud commented Jul 10, 2018

@mickaelandrieu Look like something is weird with preston when it was working yesterday -_-
Preston already has critical and refacto in its valid types and we can already add these types while creating a PR :/

@Quetzacoalt91 Quetzacoalt91 merged commit 4f4f9d2 into PrestaShop:develop Sep 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 10, 2018

Member

No need of QA review of this one, I'm merging.

Thank you @sarjon

Member

Quetzacoalt91 commented Sep 10, 2018

No need of QA review of this one, I'm merging.

Thank you @sarjon

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment