New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BOOM campaign #9303

Merged
merged 3 commits into from Sep 14, 2018

Conversation

Projects
None yet
7 participants
@fatmaBouchekoua
Contributor

fatmaBouchekoua commented Jul 11, 2018

Questions Answers
Branch? develop
Description? This PR gathers all the scenarios of the BOOM tickets in a separate campaign named "boom"
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? npm run boom -- --URL=FrontOfficeURL --DIR=DownloadDirectory --URLLASTSTABLEVERSION=LaststableversionURL --DB_SERVER=DataBaseServer --DB_USER=DataBaseUser --DB_PASSWD=DataBasePassword --RCLINK=RCDownloadlink --RCTARGET=LastStableVersionLocation --FILENAME=RCFileName --LANGUAGE=language --COUNTRY=country

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Jul 11, 2018

Contributor

Hello @fatmaBouchekoua, thanks for writing these non-regression tests 👍

Contributor

mickaelandrieu commented Jul 11, 2018

Hello @fatmaBouchekoua, thanks for writing these non-regression tests 👍

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 30, 2018

Contributor

Should I close this one, or change target branch?

Contributor

PierreRambaud commented Aug 30, 2018

Should I close this one, or change target branch?

@fatmaBouchekoua

This comment has been minimized.

Show comment
Hide comment
@fatmaBouchekoua

fatmaBouchekoua Aug 30, 2018

Contributor

Hello @PierreRambaud ,
I will change the target branch.

Contributor

fatmaBouchekoua commented Aug 30, 2018

Hello @PierreRambaud ,
I will change the target branch.

@Quetzacoalt91 Quetzacoalt91 changed the base branch from 1.7.4.x to develop Sep 11, 2018

@fatmaBouchekoua

This comment has been minimized.

Show comment
Hide comment
@fatmaBouchekoua

fatmaBouchekoua Sep 14, 2018

Contributor

@mbadrani ready to be merged !

Contributor

fatmaBouchekoua commented Sep 14, 2018

@mbadrani ready to be merged !

@mbadrani

Review and QA validation done by Fatma

@mbadrani mbadrani merged commit 589e71b into PrestaShop:develop Sep 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 removed the 1.7.4.x label Sep 21, 2018

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.5.0 milestone Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment