Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url does not update when changing product attributes #9335

Merged
merged 3 commits into from Jul 18, 2018

Conversation

Projects
None yet
5 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Jul 17, 2018

Questions Answers
Branch? 1.7.4.x
Description? Switching combination doesn't change the url.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-5929
How to test? Try switching color/size and refresh page

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.4.2 milestone Jul 17, 2018

{
id_product_attribute: args.id_product_attribute
},
undefined,

This comment has been minimized.

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Jul 18, 2018

Author Contributor

I just took what was on the previous prestashop version and from doc:a title (which is currently ignored),

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Jul 18, 2018

Author Contributor

I changed it to use document.title like in admin-theme.js

@@ -311,4 +311,17 @@ $(document).ready(() => {
}
});
});

prestashop.on('updatedProduct', (args) => {
if (!args.product_url) {

This comment has been minimized.

Copy link
@Quetzacoalt91

Quetzacoalt91 Jul 18, 2018

Member

Don't you want to check args.id_product_attribute as well?

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Jul 18, 2018

Author Contributor

Done! Thanks

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Jul 18, 2018

Author Contributor

@mickaelandrieu One more time, double review was needed :trollface:

@marionf marionf self-assigned this Jul 18, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Jul 18, 2018

@marionf marionf removed their assignment Jul 18, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit fd5e99e into PrestaShop:1.7.4.x Jul 18, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jul 18, 2018

Thank you @PierreRambaud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.