Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url does not update when changing product attributes #9335

Merged
merged 3 commits into from Jul 18, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+23 −1
Diff settings

Always

Just for now

@@ -311,4 +311,17 @@ $(document).ready(() => {
}
});
});

prestashop.on('updatedProduct', (args) => {
if (!args.product_url) {

This comment has been minimized.

Copy link
@Quetzacoalt91

Quetzacoalt91 Jul 18, 2018

Member

Don't you want to check args.id_product_attribute as well?

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Jul 18, 2018

Author Contributor

Done! Thanks

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Jul 18, 2018

Author Contributor

@mickaelandrieu One more time, double review was needed :trollface:

return;
}
window.history.pushState(
{
id_product_attribute: args.id_product_attribute
},
undefined,

This comment has been minimized.

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Jul 18, 2018

Author Contributor

I just took what was on the previous prestashop version and from doc:a title (which is currently ignored),

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Jul 18, 2018

Author Contributor

I changed it to use document.title like in admin-theme.js

args.product_url
);
});
});

Some generated files are not rendered by default. Learn more.

Oops, something went wrong.

Large diffs are not rendered by default.

Oops, something went wrong.
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.