New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rel="noopener noreferrer" #9340

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
5 participants
@rudSarkar
Contributor

rudSarkar commented Jul 17, 2018

Questions Answers
Branch? develop
Description? Little fix rel="noopener noreferrer" and http://enable-javascript.com/ to https://enable-javascript.com/
Type? improvement
Category? IN
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test?

This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Jul 17, 2018

Collaborator

Hello @rudSarkar!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Jul 17, 2018

Hello @rudSarkar!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@rudSarkar

This comment has been minimized.

Show comment
Hide comment
@rudSarkar

rudSarkar Sep 10, 2018

Contributor

What I have to do now?

Contributor

rudSarkar commented Sep 10, 2018

What I have to do now?

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 10, 2018

Member

Nothing, this PR is currently under review.

Member

Quetzacoalt91 commented Sep 10, 2018

Nothing, this PR is currently under review.

@rudSarkar

This comment has been minimized.

Show comment
Hide comment
@rudSarkar

rudSarkar Sep 10, 2018

Contributor

Thanks for the information.

Contributor

rudSarkar commented Sep 10, 2018

Thanks for the information.

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 10, 2018

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Sep 10, 2018

@PierreRambaud PierreRambaud merged commit 02b0a47 into PrestaShop:develop Sep 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud
Contributor

PierreRambaud commented Sep 10, 2018

Thanks @rudSarkar

@rudSarkar

This comment has been minimized.

Show comment
Hide comment
@rudSarkar

rudSarkar Sep 10, 2018

Contributor

Welcome ❤

Contributor

rudSarkar commented Sep 10, 2018

Welcome ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment