New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity (Selenium tests) #9341

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
5 participants
@fatmaBouchekoua
Contributor

fatmaBouchekoua commented Jul 18, 2018

Questions Answers
Branch? develop
Description? This PR adds the scenario (identity.js) that exists in the repo test/Selenium/specs
Type? new feature
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? npm run selenium-test -- --URL=URLFrontOffice

This change is Reviewable

@fatmaBouchekoua fatmaBouchekoua added the TE label Jul 18, 2018

@fatmaBouchekoua fatmaBouchekoua changed the title from Idenity (Selenium tests) to Identity (Selenium tests) Jul 18, 2018

* International Registered Trademark & Property of PrestaShop SA
*/
define('_PS_MODE_DEV_', false);

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Sep 11, 2018

Member

This file already exist in tests/E2E, why don't you reuse it?

@Quetzacoalt91

Quetzacoalt91 Sep 11, 2018

Member

This file already exist in tests/E2E, why don't you reuse it?

This comment has been minimized.

@fatmaBouchekoua

fatmaBouchekoua Sep 12, 2018

Contributor

You mean tests/Selenium?

@fatmaBouchekoua

fatmaBouchekoua Sep 12, 2018

Contributor

You mean tests/Selenium?

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Sep 12, 2018

Member

Yes, you're right.

@Quetzacoalt91

Quetzacoalt91 Sep 12, 2018

Member

Yes, you're right.

This comment has been minimized.

@fatmaBouchekoua

fatmaBouchekoua Sep 12, 2018

Contributor

This repository (tests/Selenium) will be removed soon after migrating all tests to the repository E2E, that's why I didn't use it.

@fatmaBouchekoua

fatmaBouchekoua Sep 12, 2018

Contributor

This repository (tests/Selenium) will be removed soon after migrating all tests to the repository E2E, that's why I didn't use it.

@fatmaBouchekoua

This comment has been minimized.

Show comment
Hide comment
@fatmaBouchekoua

fatmaBouchekoua Sep 21, 2018

Contributor

Scenario reviewed by @hadrich-hatem

Contributor

fatmaBouchekoua commented Sep 21, 2018

Scenario reviewed by @hadrich-hatem

@fatmaBouchekoua

This comment has been minimized.

Show comment
Hide comment
@fatmaBouchekoua

fatmaBouchekoua Sep 21, 2018

Contributor

@mbadrani this PR is ready to be merged

Contributor

fatmaBouchekoua commented Sep 21, 2018

@mbadrani this PR is ready to be merged

@mbadrani

already reviewed

@mbadrani mbadrani merged commit 8e2615f into PrestaShop:develop Sep 25, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment