New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function comment of Module class #9343

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
4 participants
@SebBareyre
Contributor

SebBareyre commented Jul 18, 2018

Questions Answers
Branch? develop
Description? fix wrong param name in displayWarning comment and add comment in displayConfirmation function
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? -

This change is Reviewable

[CO] Fix function comment
fix wrong param name in displayWarning comment
add comment in displayConfirmation function
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 31, 2018

Member

Applied CS fixer on this PR, ready to be merged once the test pass.

Member

Quetzacoalt91 commented Aug 31, 2018

Applied CS fixer on this PR, ready to be merged once the test pass.

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 31, 2018

@Quetzacoalt91 Quetzacoalt91 changed the title from [CO] Fix function comment to Fix function comment of Module class Aug 31, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 3a07601 into PrestaShop:develop Aug 31, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 31, 2018

Thank you @SebBareyre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment