New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'recommended modules' popin behavior in BO #9352

Merged
merged 1 commit into from Aug 24, 2018

Conversation

Projects
None yet
5 participants
@matks
Contributor

matks commented Jul 19, 2018

Questions Answers
Branch? develop
Description? Fix the 'recommended modules' popin behavior
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixed #9593
How to test? Go on 'carriers' page in BackOffice /admin-dev/index.php?controller=AdminCarriers/ and click on 'recommended modules' button in the top right corner of the screen. Install one module, uninstall another. The display is not pretty, but it works.

This is a duplicate of #9317 but for develop.


This change is Reviewable

@matks

This comment has been minimized.

Show comment
Hide comment
@matks

matks Aug 6, 2018

Contributor

Requested changes applied, commit amended and branch rebased on develop

Contributor

matks commented Aug 6, 2018

Requested changes applied, commit amended and branch rebased on develop

@matks

This comment has been minimized.

Show comment
Hide comment
@matks

matks Aug 21, 2018

Contributor

Branch rebased on develop again as develop has evolved quite a lot in 15 days 😛

Please merge before it needs to be rebased again ^^ @eternoendless @PierreRambaud @tomlev ?

Contributor

matks commented Aug 21, 2018

Branch rebased on develop again as develop has evolved quite a lot in 15 days 😛

Please merge before it needs to be rebased again ^^ @eternoendless @PierreRambaud @tomlev ?

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 24, 2018

Contributor

Hello @matks,

sorry for that, you can use @Quetzacoalt91 "trick" for assets: you commit them only when someone add "QA-approved" label. Our QA team knows how to update assets, you just need to tell them in pull request description.

In the next major, we will probably remove them from the Core, to ease the contribution for everyone.

Contributor

mickaelandrieu commented Aug 24, 2018

Hello @matks,

sorry for that, you can use @Quetzacoalt91 "trick" for assets: you commit them only when someone add "QA-approved" label. Our QA team knows how to update assets, you just need to tell them in pull request description.

In the next major, we will probably remove them from the Core, to ease the contribution for everyone.

@marionf marionf self-assigned this Aug 24, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Aug 24, 2018

@marionf marionf removed their assignment Aug 24, 2018

@marionf marionf added this to the 1.7.5.0 milestone Aug 24, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 24, 2018

Contributor

Hello @matks, one rebase / cs fix and I merge !

Good job :)

Contributor

mickaelandrieu commented Aug 24, 2018

Hello @matks, one rebase / cs fix and I merge !

Good job :)

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 24, 2018

Contributor

Thanks @matks and everyone for review

Contributor

mickaelandrieu commented Aug 24, 2018

Thanks @matks and everyone for review

@mickaelandrieu mickaelandrieu merged commit 528c7e6 into PrestaShop:develop Aug 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment