New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FO] Add breadcrumb to the contact page #9362

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
7 participants
@SebBareyre
Contributor

SebBareyre commented Jul 20, 2018

Questions Answers
Branch? develop
Description? add the missing breadcrumb function
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? Just visit the contact page

This change is Reviewable

[FO] Add breadcrumb to the contact page
add the missing breadcrumb function
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Jul 24, 2018

Member

Okay, this seems legit and this PR is fine technically.
However, I see there is a breadcrumb only on 2-levels pages, and on the category page. I guess there was a reason to not display it everywhere. We need a product review on this one.

ping @colinegin

Member

Quetzacoalt91 commented Jul 24, 2018

Okay, this seems legit and this PR is fine technically.
However, I see there is a breadcrumb only on 2-levels pages, and on the category page. I guess there was a reason to not display it everywhere. We need a product review on this one.

ping @colinegin

@kpodemski

This comment has been minimized.

Show comment
Hide comment
@kpodemski

kpodemski Jul 27, 2018

Contributor

@Quetzacoalt91 @colinegin

it was reported by some people in Poland as a bug, after first look at it I was also in that group of people who thought that breadcrumb should be everywhere :)

Contributor

kpodemski commented Jul 27, 2018

@Quetzacoalt91 @colinegin

it was reported by some people in Poland as a bug, after first look at it I was also in that group of people who thought that breadcrumb should be everywhere :)

@SebBareyre

This comment has been minimized.

Show comment
Hide comment
@SebBareyre

SebBareyre Jul 30, 2018

Contributor

@kpodemski : I think that breadcrumb should be everywhere too... :)

Contributor

SebBareyre commented Jul 30, 2018

@kpodemski : I think that breadcrumb should be everywhere too... :)

@colinegin colinegin added PM ✔️ and removed waiting for PM labels Aug 10, 2018

@marionf marionf self-assigned this Sep 4, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Sep 4, 2018

@marionf marionf removed their assignment Sep 4, 2018

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.5.0 milestone Sep 4, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 4, 2018

Thank you @SebBareyre

@Quetzacoalt91 Quetzacoalt91 merged commit 70dc18e into PrestaShop:develop Sep 4, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment