New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ajax in 500 in product page #9399

Merged
merged 3 commits into from Aug 6, 2018

Conversation

Projects
None yet
5 participants
@PierreRambaud
Contributor

PierreRambaud commented Aug 2, 2018

Questions Answers
Branch? develop
Description? There's a xhr with 500 in response when editing product and add combination without combination products. (Error but no impact)
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Watch console, having a 500 like http://ps-develop.localhost/admin-dev/index.php/sell/catalog/products/combinations/form/index.php?controller=AdminDashboard&token=08052cc025395748130af4b974fd4cf1 before using this patch.

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 2, 2018

@ntiepresta ntiepresta requested review from ntiepresta and removed request for ntiepresta Aug 3, 2018

@ntiepresta ntiepresta self-assigned this Aug 3, 2018

@ntiepresta ntiepresta removed their assignment Aug 3, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Aug 3, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 6, 2018

Contributor

@PierreRambaud one more rebase and I'll merge

Contributor

mickaelandrieu commented Aug 6, 2018

@PierreRambaud one more rebase and I'll merge

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 6, 2018

Contributor

Done

Contributor

PierreRambaud commented Aug 6, 2018

Done

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 6, 2018

Contributor

And merged! Thank you @PierreRambaud

Contributor

mickaelandrieu commented Aug 6, 2018

And merged! Thank you @PierreRambaud

@mickaelandrieu mickaelandrieu merged commit 43077ae into PrestaShop:develop Aug 6, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/product-500 branch Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment