New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gsitemap #9404

Merged
merged 2 commits into from Aug 6, 2018

Conversation

Projects
None yet
6 participants
@eternoendless
Member

eternoendless commented Aug 3, 2018

Questions Answers
Branch? develop
Description? Includes gsitemap as a native module
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? The module is installed with PS and works with 1.7

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.5.0 milestone Aug 3, 2018

@marionf marionf self-assigned this Aug 3, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Aug 3, 2018

@marionf marionf removed their assignment Aug 3, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 3d43589 into PrestaShop:develop Aug 6, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 6, 2018

Thank you @eternoendless

@eternoendless eternoendless deleted the eternoendless:add-gsitemap branch Aug 6, 2018

@Mreker

This comment has been minimized.

Show comment
Hide comment
@Mreker

Mreker Aug 8, 2018

Contributor

@eternoendless I just made a lot of changes to the sitemap module. I solved every reported bug. I made it compatible with bootstrap and fixed a lot of issues. If I make a pull request on the module page, will you check it out?
screenshot_2018-08-08 modules services demo

Contributor

Mreker commented Aug 8, 2018

@eternoendless I just made a lot of changes to the sitemap module. I solved every reported bug. I made it compatible with bootstrap and fixed a lot of issues. If I make a pull request on the module page, will you check it out?
screenshot_2018-08-08 modules services demo

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 8, 2018

Contributor

@Mreker Of course we will check it! We are always glad to view and comment a pull request to improve everything that can be improved!

Contributor

PierreRambaud commented Aug 8, 2018

@Mreker Of course we will check it! We are always glad to view and comment a pull request to improve everything that can be improved!

@Mreker

This comment has been minimized.

Show comment
Hide comment
@Mreker

Mreker Aug 8, 2018

Contributor

Please check this: PrestaShop/gsitemap#53

I did put a lot of work into the module in order to fix all the bugs I could find.

Contributor

Mreker commented Aug 8, 2018

Please check this: PrestaShop/gsitemap#53

I did put a lot of work into the module in order to fix all the bugs I could find.

@Mreker

This comment has been minimized.

Show comment
Hide comment
@Mreker

Mreker Aug 8, 2018

Contributor

gsitemap.zip

or you can try it here

Contributor

Mreker commented Aug 8, 2018

gsitemap.zip

or you can try it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment