New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grid search and reset buttons #9410

Merged
merged 4 commits into from Aug 7, 2018

Conversation

Projects
None yet
6 participants
@sarjon
Member

sarjon commented Aug 6, 2018

Questions Answers
Branch? develop
Description? Updates Search & Reset buttons of Grid filters. See screenshots below.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Searching & filtering should work the same.

This is how buttons where displayed before (both are visible all the time):
before_search_and_reset

This is how buttons are displayed now (only search is visible when filters are empty and reset is show after submitting filters):
after_search
after_search_and_reset


This change is Reviewable

@sarjon

This comment has been minimized.

Show comment
Hide comment
@sarjon

sarjon Aug 6, 2018

Member

@mickaelandrieu what do you think about this change?

Member

sarjon commented Aug 6, 2018

@mickaelandrieu what do you think about this change?

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 7, 2018

Contributor

I think @marionf will like it :)

Contributor

mickaelandrieu commented Aug 7, 2018

I think @marionf will like it :)

@marionf marionf self-assigned this Aug 7, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Aug 7, 2018

Contributor

I still have the issue with the reset button that doesn't always reset
Otherwise, everything is good

Contributor

marionf commented Aug 7, 2018

I still have the issue with the reset button that doesn't always reset
Otherwise, everything is good

@marionf marionf removed their assignment Aug 7, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Aug 7, 2018

@mickaelandrieu mickaelandrieu merged commit 300842e into PrestaShop:develop Aug 7, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 10, 2018

@matks matks added the migration label Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment