New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indian Localization improved #9411

Merged
merged 1 commit into from Aug 8, 2018

Conversation

Projects
None yet
5 participants
@adhavalboy
Contributor

adhavalboy commented Aug 6, 2018

Questions Answers
Branch? develop
Description? Indian localization Improved
Type? improvement
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? here is the list https://en.wikipedia.org/wiki/States_and_union_territories_of_India

This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Aug 6, 2018

Collaborator

Hello @adhavalboy!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Aug 6, 2018

Hello @adhavalboy!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added the Bug label Aug 6, 2018

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 7, 2018

Contributor

Hi,

Can you complete the description, branch, and how we can test? What it fix exactly?

Regards

Contributor

PierreRambaud commented Aug 7, 2018

Hi,

Can you complete the description, branch, and how we can test? What it fix exactly?

Regards

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 7, 2018

Contributor

Hello, I'm not sure this is a fix... imo you have utf8 encoding issues on your own shop and you're changing correct translations to fix it: don't you?

Looking at the very first translation you have changed: http://www.citypopulation.de/India-ArunachalPradesh.html is the right syntax.

So, I'm against this changes in the core 👎

Contributor

mickaelandrieu commented Aug 7, 2018

Hello, I'm not sure this is a fix... imo you have utf8 encoding issues on your own shop and you're changing correct translations to fix it: don't you?

Looking at the very first translation you have changed: http://www.citypopulation.de/India-ArunachalPradesh.html is the right syntax.

So, I'm against this changes in the core 👎

@adhavalboy

This comment has been minimized.

Show comment
Hide comment
@adhavalboy

adhavalboy Aug 7, 2018

Contributor

In India, people are generally writing as I proposed many see this pic of e-commerce site of India
screenshot_20180807_152613

Contributor

adhavalboy commented Aug 7, 2018

In India, people are generally writing as I proposed many see this pic of e-commerce site of India
screenshot_20180807_152613

@adhavalboy

This comment has been minimized.

Show comment
Hide comment
@adhavalboy

adhavalboy Aug 7, 2018

Contributor

You are Following German-English script convention but localization for India-English script is different and localization purpose is to understand locally. I am from India, We are never writing as previously written.

Contributor

adhavalboy commented Aug 7, 2018

You are Following German-English script convention but localization for India-English script is different and localization purpose is to understand locally. I am from India, We are never writing as previously written.

@adhavalboy adhavalboy changed the title from script fix to Indian Localisation improved Aug 7, 2018

@adhavalboy adhavalboy changed the title from Indian Localisation improved to Indian Localization improved Aug 7, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 7, 2018

Contributor

Hello @adhavalboy fair enough, thanks for completion of the description and the explanation.

Contributor

mickaelandrieu commented Aug 7, 2018

Hello @adhavalboy fair enough, thanks for completion of the description and the explanation.

@marionf marionf assigned marionf and unassigned marionf Aug 7, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Aug 7, 2018

@PierreRambaud PierreRambaud merged commit 5a9deb6 into PrestaShop:develop Aug 8, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 8, 2018

Contributor

Thansk a lot @adhavalboy

Contributor

PierreRambaud commented Aug 8, 2018

Thansk a lot @adhavalboy

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 10, 2018

@prestonBot prestonBot added the develop label Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment