New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid composer authentication issues #9412

Merged
merged 1 commit into from Aug 8, 2018

Conversation

Projects
None yet
4 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Aug 7, 2018

Questions Answers
Branch? develop
Description? Are you bored to restart again and again Travis builds cause we have too much and Composer complains about Github authentication issues/limits? Merge it and it will become an old nightmare
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
How to test? As a note, the token has no authorizations at all on PrestaShop, to be honest, the account used is created for this purpose only (@prestatoken).

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 8, 2018

Contributor

Hello @PierreRambaud,

I guess you can merge without QA?

Contributor

mickaelandrieu commented Aug 8, 2018

Hello @PierreRambaud,

I guess you can merge without QA?

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Aug 8, 2018

@PierreRambaud PierreRambaud merged commit 456aaa1 into PrestaShop:develop Aug 8, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the mickaelandrieu:build/improve-composer-auth branch Aug 8, 2018

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 8, 2018

Contributor

@mickaelandrieu You're right, just waiting for feedback from others developers but they look like busy :P
Thanks again ;)

Contributor

PierreRambaud commented Aug 8, 2018

@mickaelandrieu You're right, just waiting for feedback from others developers but they look like busy :P
Thanks again ;)

@jolelievre

This comment has been minimized.

Show comment
Hide comment
@jolelievre

jolelievre Aug 9, 2018

Contributor

nice way to add comment in jsons ^^

Contributor

jolelievre commented Aug 9, 2018

nice way to add comment in jsons ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment