Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
FO: override CustomerAddressForm->submit method more easily #9417
now you can override CustomerAddressForm->submit method more easily without trying to hack private variables
changed the title from
FO: now you can override CustomerAddressForm->submit method more easily
FO: override CustomerAddressForm->submit method more easily
Aug 7, 2018
Aug 8, 2018
referenced this pull request
Aug 8, 2018
Let's be clear on it: we don't expect you to make a module that only copy paste a whole class and alter 2 lines, and modules with overrides are forbidden in PrestaShop Addons Store. If properties are private, this is for a good reason: except $address property, all others properties must not be altered as they may broke the intended behavior.
I will update this class.
@rGaillard and this make the maintenance, the upgrade and the reputation of our product bad since years, I know.
We have already announced many times that this practice (overrides in specific folder) is discouraged and we are deprecating it to be able to remove it in the next major.
You may agree or not, but the easiest way to alter a behavior is using an hook: the performance issue isn't worth the upgrade issues (and can be solved).
@rGaillard you are right about what you said and its very easy way to change/fix things for small teams/agencies but i really wonder if 2 different people overrides same class what will happen, i can see that module conflict[SOLVED] titled forum topics from here
@azisyus this is why we're willing to remove this feature and include more hooks and docs to make shops more stable. I don't say this won't be "as easy" as before, but I can promise we're working on it to ease the work of developers on maintenance and upgrade