New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment line to Address.php #9426

Merged
merged 2 commits into from Aug 14, 2018

Conversation

Projects
None yet
5 participants
@azisyus
Contributor

azisyus commented Aug 8, 2018

Questions Answers
Branch? develop
Description? when you dont know this thing, its takes little bit time to discover the real reason of exception, exception is in in AddressChecksumCore.php line 50 but when you remove allow_null=>true it just works fine
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? its just comment line

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 13, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 82a08fe into PrestaShop:develop Aug 14, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 14, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 14, 2018

Contributor

Wow, it was merged so fast!!! #privateJoke

Contributor

mickaelandrieu commented Aug 14, 2018

Wow, it was merged so fast!!! #privateJoke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment