New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused taxes #9436

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
4 participants
@Mreker
Contributor

Mreker commented Aug 11, 2018

Questions Answers
Branch? develop
Description? There are online one tax in Denmark (25%)
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? There should only be one available tax for Denmark.

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 13, 2018

Contributor

Hello @Mreker,

would you mind to share us a link to be able to check for it?

As developers, we're not really aware of taxes applied in Denmark :)

Thanks for your understanding.

Contributor

mickaelandrieu commented Aug 13, 2018

Hello @Mreker,

would you mind to share us a link to be able to check for it?

As developers, we're not really aware of taxes applied in Denmark :)

Thanks for your understanding.

@Mreker

This comment has been minimized.

Show comment
Hide comment
@Mreker

Mreker Aug 13, 2018

Contributor

@mickaelandrieu

VAT / “Moms”
In addition, a 25% VAT (known as “Moms” in Danish) is charged on virtually all goods. VAT is typically included in the prices you see as a normal consumer. This includes groceries, books, drinks, café/restaurant menus, etc.

link: http://www.expatindenmark.com/livingindenmark/pages/taxes.aspx

I live in Denmark. We do only have one VAT rule of 25%. As you can see by the code I deleted, the VAT from books etc. was 25% as well.

Contributor

Mreker commented Aug 13, 2018

@mickaelandrieu

VAT / “Moms”
In addition, a 25% VAT (known as “Moms” in Danish) is charged on virtually all goods. VAT is typically included in the prices you see as a normal consumer. This includes groceries, books, drinks, café/restaurant menus, etc.

link: http://www.expatindenmark.com/livingindenmark/pages/taxes.aspx

I live in Denmark. We do only have one VAT rule of 25%. As you can see by the code I deleted, the VAT from books etc. was 25% as well.

@ntiepresta ntiepresta self-assigned this Aug 13, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Aug 13, 2018

@ntiepresta ntiepresta removed their assignment Aug 13, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 13, 2018

Contributor

Thanks @Mreker and everyone for the review

Contributor

mickaelandrieu commented Aug 13, 2018

Thanks @Mreker and everyone for the review

@mickaelandrieu mickaelandrieu merged commit 29b734e into PrestaShop:develop Aug 13, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment