New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 403 error when accessing localhost using IPv6 (Maxmind Database exists) #9441

Merged
merged 1 commit into from Aug 14, 2018

Conversation

Projects
None yet
6 participants
@tolispy
Contributor

tolispy commented Aug 13, 2018

You can not access prestashop front office, when visiting localhost, after install Maxmind Database.
This is happening only when IPv6 is activated, and localhost is resolving to IPv6.

You get an access denied page, because function displayRestrictedCountryPage() is firing at line 472 in version 1.7.4.2.

This fix apply the same logic, that is already applied when we visit localhost using IPv4

Questions Answers
Branch? develop
Description? In a PC that use IPv6, after installing Maxmind Database, front office is not accessible
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-6169
How to test? Visit localhost using IPv6, after installing Maxmind Database

This change is Reviewable

Fix 403 error when accessing localhost using IPv6 (Maxmind Database e…
…xists)

You can not access prestashop frontend, when visiting localhost, after install Maxmind Database.
This is happening only when IPv6 is activated, and localhost is resolving to IPv6.
Then displayRestrictedCountryPage() function is firing at line 472 in version 1.7.4.2.

This fix apply the same logic, that is already applied when we visit localhost using IPv4
@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Aug 13, 2018

Collaborator

Hello @tolispy!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Aug 13, 2018

Hello @tolispy!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 13, 2018

Contributor

Nice catch!

Contributor

PierreRambaud commented Aug 13, 2018

Nice catch!

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 14, 2018

Contributor

@Quetzacoalt91 do we need a QA approval or LGTM?

Contributor

mickaelandrieu commented Aug 14, 2018

@Quetzacoalt91 do we need a QA approval or LGTM?

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Aug 14, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 14, 2018

Member

A QA check is always nice to have. :)

Member

Quetzacoalt91 commented Aug 14, 2018

A QA check is always nice to have. :)

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 14, 2018

Contributor

@Quetzacoalt91 then someone may help @marionf or @ntiepresta to install Maxmind Database ^^

Contributor

mickaelandrieu commented Aug 14, 2018

@Quetzacoalt91 then someone may help @marionf or @ntiepresta to install Maxmind Database ^^

@ntiepresta ntiepresta self-assigned this Aug 14, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit f22a8bf into PrestaShop:develop Aug 14, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 14, 2018

Member

I checked the changes. Thank you @tolispy

Member

Quetzacoalt91 commented Aug 14, 2018

I checked the changes. Thank you @tolispy

@tolispy tolispy deleted the tolispy:fix-BOOM-6169 branch Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment