New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple filters and columns #9442

Merged
merged 11 commits into from Aug 17, 2018

Conversation

Projects
None yet
5 participants
@sarjon
Member

sarjon commented Aug 13, 2018

Questions Answers
Branch? develop
Description? See PrestaShop/prestafony-project#62
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Email logs, Logs and Sql Manager grids should work the same.

This change is Reviewable

@sarjon

This comment has been minimized.

Show comment
Hide comment
@sarjon

sarjon Aug 13, 2018

Member

@mickaelandrieu can you take a look?

Member

sarjon commented Aug 13, 2018

@mickaelandrieu can you take a look?

@mickaelandrieu

This need unit tests and update of grid docs but yes, I agree on decoupling filters to columns.

Good job @sarjon

*
* @return string
*/
protected function trans($id, array $options, $domain)

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Aug 13, 2018

Contributor

👍

@mickaelandrieu
@sarjon

This comment has been minimized.

Show comment
Hide comment
@sarjon

sarjon Aug 13, 2018

Member

Updated Logs grid & unit tests. 👍

Member

sarjon commented Aug 13, 2018

Updated Logs grid & unit tests. 👍

@sarjon sarjon changed the title from [WIP] Decouple filters and columns to Decouple filters and columns Aug 13, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 14, 2018

Contributor

Hello @PrestaShop/prestashop-core-developers I'd like someone to review in order to learn a little bit about the Grid system please 👍 . Docs will come, but how can we validate it if we don't know how it works?

Contributor

mickaelandrieu commented Aug 14, 2018

Hello @PrestaShop/prestashop-core-developers I'd like someone to review in order to learn a little bit about the Grid system please 👍 . Docs will come, but how can we validate it if we don't know how it works?

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 17, 2018

Contributor

Hello @sarjon, a little rebase here please so I can validate and merge this contribution.

Contributor

mickaelandrieu commented Aug 17, 2018

Hello @sarjon, a little rebase here please so I can validate and merge this contribution.

@sarjon

This comment has been minimized.

Show comment
Hide comment
@sarjon
Member

sarjon commented Aug 17, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu
Contributor

mickaelandrieu commented Aug 17, 2018

good2me

@mickaelandrieu mickaelandrieu merged commit 8166638 into PrestaShop:develop Aug 17, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 17, 2018

Contributor

Thanks @sarjon !

Contributor

mickaelandrieu commented Aug 17, 2018

Thanks @sarjon !

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Aug 17, 2018

@matks matks added the migration label Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment