New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search engine result preview on product page #9444

Merged
merged 9 commits into from Sep 7, 2018

Conversation

@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 13, 2018

Questions Answers
Branch? develop
Description? Add a search engine result preview in the product page, SEO tab
Type? new feature
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? #10046
How to test? You should have a Google style search preview in the SEO tab. Modifying the inputs meta title & meta description must update the preview.

capture du 2018-08-13 14-25-15


This change is Reviewable

@mickaelandrieu

few comments here, I'm anxious about adding Vuejs in such broken page lol

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 13, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 14, 2018

Member

@mickaelandrieu, I understand that you're concerned about loading new feature to the product page, but note this component and the global page behavior are not dependent from each other.

This component will be also added on two other pages, once migrated:

  • SEO & URLs
  • Category
Member

Quetzacoalt91 commented Aug 14, 2018

@mickaelandrieu, I understand that you're concerned about loading new feature to the product page, but note this component and the global page behavior are not dependent from each other.

This component will be also added on two other pages, once migrated:

  • SEO & URLs
  • Category
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 24, 2018

Contributor

This one must be rebased please @Quetzacoalt91 :)

Contributor

PierreRambaud commented Aug 24, 2018

This one must be rebased please @Quetzacoalt91 :)

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Sep 6, 2018

Contributor

@Quetzacoalt91

If I edit the meta description, it's not changed

capture d ecran_279

Contributor

marionf commented Sep 6, 2018

@Quetzacoalt91

If I edit the meta description, it's not changed

capture d ecran_279

@marionf marionf removed their assignment Sep 6, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 6, 2018

Member

See 6c67641 for the fix.

Member

Quetzacoalt91 commented Sep 6, 2018

See 6c67641 for the fix.

@matks matks dismissed their stale review via 2174acb Sep 7, 2018

@matks

matks approved these changes Sep 7, 2018

@matks

This comment has been minimized.

Show comment
Hide comment
@matks

matks Sep 7, 2018

Contributor

@marionf You validated this PR but it got back into "To be review" state. I think the changes should not modify your validation however I leave the decision to re-validate or allow the merge to you.

Contributor

matks commented Sep 7, 2018

@marionf You validated this PR but it got back into "To be review" state. I think the changes should not modify your validation however I leave the decision to re-validate or allow the merge to you.

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Sep 7, 2018

Contributor

I did a last check and it's all good, so let's merge it :)

Contributor

marionf commented Sep 7, 2018

I did a last check and it's all good, so let's merge it :)

@matks matks merged commit baa5ddc into PrestaShop:develop Sep 7, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment