New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change out of stock condition with greater or equals #9445

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
5 participants
@jolelievre
Contributor

jolelievre commented Aug 13, 2018

Questions Answers
Branch? develop
Description? Change out of stock condition with greater or equals, this will prevent the bug on the product page displaying the "Out of stock" warning when you try the order the EXACT amount of products in stock
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-6229
How to test? Try to order a product with the exact number of available products, the cart button must remain active and no warning is shown

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 13, 2018

@marionf marionf self-assigned this Aug 13, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Aug 13, 2018

@marionf marionf removed their assignment Aug 13, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 13, 2018

Contributor

Thanks @jolelievre and everyone for the review!

Contributor

mickaelandrieu commented Aug 13, 2018

Thanks @jolelievre and everyone for the review!

@mickaelandrieu mickaelandrieu merged commit 4087ce1 into PrestaShop:develop Aug 13, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jolelievre jolelievre deleted the jolelievre:BOOM-6229 branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment