New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications tab + new hierarchy #9454

Merged
merged 25 commits into from Aug 29, 2018

Conversation

Projects
None yet
7 participants
@PierreRambaud
Contributor

PierreRambaud commented Aug 16, 2018

Questions Answers
Branch? develop
Description? Reorganize menu, new hierarchy, separates tabs. Was @Quetzacoalt91 work, just add refactoring to prepare new categories.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10050 #10049
How to test? Follow tickets instructions

This change is Reviewable

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 23, 2018

Contributor

@Quetzacoalt91 Can you have a review on this? :)

Contributor

PierreRambaud commented Aug 23, 2018

@Quetzacoalt91 Can you have a review on this? :)

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Aug 24, 2018

Contributor

@PierreRambaud & @Quetzacoalt91

In This ticket, it seems Installed modules should be rename in Modules and Selection in Module catalog. Currently, it's not.

Also, in Alerts and Updates tabs, modules are not sorted by categories available on addons

capture d ecran_205

capture d ecran_206

Contributor

marionf commented Aug 24, 2018

@PierreRambaud & @Quetzacoalt91

In This ticket, it seems Installed modules should be rename in Modules and Selection in Module catalog. Currently, it's not.

Also, in Alerts and Updates tabs, modules are not sorted by categories available on addons

capture d ecran_205

capture d ecran_206

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 24, 2018

Member

@marionf The categories are not part of this PR. This is another issue to be done: #10048

Member

Quetzacoalt91 commented Aug 24, 2018

@marionf The categories are not part of this PR. This is another issue to be done: #10048

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 27, 2018

Contributor

@marionf @Quetzacoalt91 Seen with Lou, Menu is ok now =)

Contributor

PierreRambaud commented Aug 27, 2018

@marionf @Quetzacoalt91 Seen with Lou, Menu is ok now =)

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 28, 2018

Contributor

@marionf @Quetzacoalt91 Seen with Lou, Menu is ok now =)

so LGTM?

Contributor

mickaelandrieu commented Aug 28, 2018

@marionf @Quetzacoalt91 Seen with Lou, Menu is ok now =)

so LGTM?

@marionf marionf added QA ✔️ and removed waiting for QA labels Aug 29, 2018

@marionf marionf removed their assignment Aug 29, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit cee129f into PrestaShop:develop Aug 29, 2018

1 of 3 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
code-review/reviewable 26 files left
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:feature/ff-175-176 branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment