New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify product canonical url and title value #9456

Merged
merged 2 commits into from Aug 31, 2018

Conversation

Projects
None yet
5 participants
@jolelievre
Contributor

jolelievre commented Aug 16, 2018

Questions Answers
Branch? develop
Description? Modify product canonical url and title value for SEO purposes, the title contains the combination attribute infos, the canonical url is the default combination
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9508
How to test? In the product page source code check the canonical tag and the title page, title has the current page attributes, canonical is the default combination Try changing the default combination in the admin and check the canonical has changed

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.5.0 milestone Aug 16, 2018

@mickaelandrieu

Some code smells, minor fixes to address.

Good job @jolelievre !

Show outdated Hide outdated controllers/front/ProductController.php
Show outdated Hide outdated controllers/front/ProductController.php
@jolelievre

This comment has been minimized.

Show comment
Hide comment
@jolelievre

jolelievre Aug 20, 2018

Contributor

@mickaelandrieu modifications done on private methods

Contributor

jolelievre commented Aug 20, 2018

@mickaelandrieu modifications done on private methods

@mickaelandrieu

about the refactoring ok, but you may have to execute the following command: php bin/php-cs-fixer fix

@jolelievre

This comment has been minimized.

Show comment
Hide comment
@jolelievre

jolelievre Aug 30, 2018

Contributor

Done! but isn't the command rather php ./vendor/bin/php-cs-fixer fix ?

Contributor

jolelievre commented Aug 30, 2018

Done! but isn't the command rather php ./vendor/bin/php-cs-fixer fix ?

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 30, 2018

Contributor

@jolelievre Yep. Thinking he writes it fast :D

Contributor

PierreRambaud commented Aug 30, 2018

@jolelievre Yep. Thinking he writes it fast :D

@marionf marionf self-assigned this Aug 30, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Aug 30, 2018

@marionf marionf removed their assignment Aug 30, 2018

Cs fixer is ok now =)

@PierreRambaud PierreRambaud merged commit 10ca7ff into PrestaShop:develop Aug 31, 2018

2 of 3 checks passed

code-review/reviewable 2 files, 5 discussions left (mickaelandrieu, PierreRambaud)
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud
Contributor

PierreRambaud commented Aug 31, 2018

Thanks @jolelievre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment