New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong rules in robots.txt #9462

Merged
merged 4 commits into from Aug 20, 2018

Conversation

Projects
None yet
4 participants
@eternoendless
Member

eternoendless commented Aug 20, 2018

Questions Answers
Branch? develop
Description? Read below
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Use this tool on http://fo.demo.prestashop.com, paste the contents of generated robots.txt, make sure "check resources" and "test edited file" is on. All elements on the page should be allowed.

Until now, robots.txt was blocking not only directories at the root, but also directories named the same in any subdirectory.

This has been changed in order to avoid accidentally blocking assets like CSS and JS, for example.

Non existent directories like "/css" and "/web" have been removed, while missing directories like "/app", "/var" have been added.


This change is Reviewable

eternoendless added some commits Aug 20, 2018

Fix incorrect paths in robots.txt
Until now, robots.txt was blocking not only directories at the root,
but also directories named the same in any subdirectory.

This has been changed in order to avoid accidentally blocking assets
like CSS and JS, for example.

Non existent directories like "/css" and "/web" have been removed,
while missing directories like "/app", "/var" have been added.

@eternoendless eternoendless added this to the 1.7.5.0 milestone Aug 20, 2018

@marionf marionf self-assigned this Aug 20, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Aug 20, 2018

@marionf marionf removed their assignment Aug 20, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Aug 20, 2018

Member

Thanks guys

Member

eternoendless commented Aug 20, 2018

Thanks guys

@eternoendless eternoendless merged commit df6dbc9 into PrestaShop:develop Aug 20, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless deleted the eternoendless:robots-allow-css-js branch Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment