New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 'edit specific price' button on BO Product page which opens a pop-in #9465

Merged
merged 15 commits into from Aug 28, 2018

Conversation

Projects
None yet
7 participants
@matks
Contributor

matks commented Aug 21, 2018

Questions Answers
Branch? develop
Description? In BackOffice "Catalog" > "Products", currently admins can either "add" or "delete" a "specific price" on the "Edit a Product" page. This PR enables to edit a specific price.
Type? new feature
Category? BO
BC breaks? yes, see below
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/FF-160 and http://forge.prestashop.com/browse/BOOM-6300
How to test? See below

Ticket scope

This feature has 3 goals for the "edit a product" / "specific prices" panel:

  • move the "add a specific price" form above the specific prices list
  • move the javascript code which handles this form behavior into new-theme
  • enable a "edit a specific price" button which opens a form in a pop-in

A 4th goal was added during the development as I found a bug on this form. I reported it in the forge (http://forge.prestashop.com/browse/BOOM-6300) and solved it in this PR.

This PR replaces #9388 as the previous PR did not use a pop-in. The spec changed so I created a new PR. However I fixed the requested changes of the previous PR in this new PR.

How to test

Go on a "Edit a product" page on the BackOffice for 1 product. Click on "add a specific price" to display a form which allows to create specific prices. Create 2 or 3 of them so that you have a listing of prices with multiple items in it.

Now you can check that:

  • When you click on the "add a specific price" button a new form appears above the listing
  • When you click on the "edit" icon for 1 price, a pop-in appears with a form in it pre-filled with the settings of the selected price. You can modify the settings and click on "apply" to modify the price. Check the different buttons work correctly.

Be careful: in multi-shop context another field appears in the form. Also products with combination have another form field that single-combination products do not display. So test with a product with combinations and with a product without.

Translations

2 translations have been added following @LouiseBonnard directions


This change is Reviewable

@matks

This comment has been minimized.

Show comment
Hide comment
@matks

matks Aug 22, 2018

Contributor

@PierreRambaud Requested changes have been applied in e0c75be. Please re-review and, if relevant, approve 😃

Contributor

matks commented Aug 22, 2018

@PierreRambaud Requested changes have been applied in e0c75be. Please re-review and, if relevant, approve 😃

@matks

This comment has been minimized.

Show comment
Hide comment
@matks

matks Aug 24, 2018

Contributor

@PierreRambaud PR rebased to comply with coding standards (php-cs-fixer).

Please approve and merge 🙏 😄 ?

Contributor

matks commented Aug 24, 2018

@PierreRambaud PR rebased to comply with coding standards (php-cs-fixer).

Please approve and merge 🙏 😄 ?

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 28, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Aug 28, 2018

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud
Contributor

PierreRambaud commented Aug 28, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 28, 2018

Contributor

Reviewed and validated by QA => LGTM

Contributor

mickaelandrieu commented Aug 28, 2018

Reviewed and validated by QA => LGTM

@mickaelandrieu mickaelandrieu merged commit 96b0adc into PrestaShop:develop Aug 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Aug 28, 2018

Contributor

Thanks @matks !

Contributor

PierreRambaud commented Aug 28, 2018

Thanks @matks !

@matks matks deleted the matks:FF-160_enable-edit-specific-price-2 branch Aug 28, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Aug 29, 2018

Contributor

Some issues here: #10175

Contributor

marionf commented Aug 29, 2018

Some issues here: #10175

@colinegin

This comment has been minimized.

Show comment
Hide comment
@colinegin

colinegin commented Aug 29, 2018

Fixes #10171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment