New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix combination generation #9466

Merged
merged 4 commits into from Aug 23, 2018

Conversation

Projects
None yet
7 participants
@tomlev
Member

tomlev commented Aug 21, 2018

Questions Answers
Branch? develop
Description? fix error 500 while generating product combinations
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-6290
How to test? Create a product with combinations. Save. Select combinations and click on generate. You should not hav 500 error in console anymore

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 21, 2018

@PierreRambaud PierreRambaud added the Bug label Aug 21, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Aug 21, 2018

Contributor

@tomlev

No more 500 👍

The modal with bulk actions is still disabled after clicking on generate, I think it was because of the 500 but it's not

capture d ecran_187

Contributor

marionf commented Aug 21, 2018

@tomlev

No more 500 👍

The modal with bulk actions is still disabled after clicking on generate, I think it was because of the 500 but it's not

capture d ecran_187

@jolelievre

This comment has been minimized.

Show comment
Hide comment
@jolelievre

jolelievre Aug 22, 2018

Contributor

seems good to me!

Contributor

jolelievre commented Aug 22, 2018

seems good to me!

@jolelievre jolelievre self-requested a review Aug 22, 2018

@marionf marionf removed their assignment Aug 22, 2018

@marionf marionf added the QA ✔️ label Aug 22, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 22, 2018

Contributor

this needs a rebase from develop branch for coding styles :-)

Contributor

mickaelandrieu commented Aug 22, 2018

this needs a rebase from develop branch for coding styles :-)

@matks

matks approved these changes Aug 23, 2018

@matks

This comment has been minimized.

Show comment
Hide comment
@matks

matks Aug 23, 2018

Contributor

Thanks @tomlev

Contributor

matks commented Aug 23, 2018

Thanks @tomlev

@matks matks merged commit d4e8d14 into PrestaShop:develop Aug 23, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment