New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build core theme using Webpack 4 and jQuery 2.2.4 #9467

Merged
merged 2 commits into from Aug 21, 2018

Conversation

Projects
None yet
7 participants
@eternoendless
Member

eternoendless commented Aug 21, 2018

Questions Answers
Branch? develop
Description? This upgrades webpack in the core theme to v4 (up from v1!) and jQuery from v2.1.4 to v2.2.4
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? The FO should continue to work as before

This PR also compresses the built file core.js, reducing the file size by over 50%: 269K before --> 113K now.


This change is Reviewable

eternoendless added some commits Aug 21, 2018

Update Webpack to v4 for core themes
Also update jQuery to v2.2.4 for all themes.
@Mreker

This comment has been minimized.

Show comment
Hide comment
@Mreker

Mreker Aug 21, 2018

Contributor

@eternoendless can you update htmlpurifier too? :-) Link: http://htmlpurifier.org/

Contributor

Mreker commented Aug 21, 2018

@eternoendless can you update htmlpurifier too? :-) Link: http://htmlpurifier.org/

@Mreker

This comment has been minimized.

Show comment
Hide comment
@Mreker

Mreker Aug 21, 2018

Contributor

HTML Purifier 4.10.0 is a maintenance release, collecting a year of accumulated bug fixes. The most critical fixes relate to supporting PHP 7.2 properly, and there are a few other minor fixes. One thing on the feature front: relative CSS length specifiers are now supported. Additionally, we have officially dropped support for PHP 5.3; while we have not purposely broken HTML Purifier for this version, we are no longer testing for it.

Contributor

Mreker commented Aug 21, 2018

HTML Purifier 4.10.0 is a maintenance release, collecting a year of accumulated bug fixes. The most critical fixes relate to supporting PHP 7.2 properly, and there are a few other minor fixes. One thing on the feature front: relative CSS length specifiers are now supported. Additionally, we have officially dropped support for PHP 5.3; while we have not purposely broken HTML Purifier for this version, we are no longer testing for it.

@ntiepresta ntiepresta self-assigned this Aug 21, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Aug 21, 2018

@ntiepresta ntiepresta removed their assignment Aug 21, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 21, 2018

Contributor

@Mreker would you mind to contribution a pull request for it?

I'm in favor of this update too, just looking for you to help us a little bit 👍

Contributor

mickaelandrieu commented Aug 21, 2018

@Mreker would you mind to contribution a pull request for it?

I'm in favor of this update too, just looking for you to help us a little bit 👍

@mickaelandrieu mickaelandrieu merged commit 3c513b5 into PrestaShop:develop Aug 21, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 21, 2018

Contributor

Well played @eternoendless and thanks for QA review

Contributor

mickaelandrieu commented Aug 21, 2018

Well played @eternoendless and thanks for QA review

@eternoendless eternoendless deleted the eternoendless:themes-wp4 branch Aug 22, 2018

@mortenhartvig

This comment has been minimized.

Show comment
Hide comment
@mortenhartvig

mortenhartvig Aug 30, 2018

Thanks for finally compressing the core.js file. Now Google Pagespeed insights may finally stop nagging about it (UX designers/theme developers should really focus on this, as it directly affects how successful Prestashop is considered vs. other software) 👍

mortenhartvig commented Aug 30, 2018

Thanks for finally compressing the core.js file. Now Google Pagespeed insights may finally stop nagging about it (UX designers/theme developers should really focus on this, as it directly affects how successful Prestashop is considered vs. other software) 👍

@Mreker

This comment has been minimized.

Show comment
Hide comment
@Mreker

Mreker Sep 11, 2018

Contributor

@mickaelandrieu here you go #10376 😃

Contributor

Mreker commented Sep 11, 2018

@mickaelandrieu here you go #10376 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment