New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Back Office default theme using Webpack 4 #9471

Merged
merged 4 commits into from Sep 4, 2018

Conversation

Projects
None yet
5 participants
@eternoendless
Member

eternoendless commented Aug 21, 2018

Questions Answers
Branch? develop
Description? This upgrades webpack in the back office default theme to v4
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Legacy pages in the BO should continue to work as before

This change is Reviewable

@CaptainYouz

Reviewed 3 of 5 files at r1.
Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions (waiting on @eternoendless)


admin-dev/themes/default/package.json, line 16 at r1 (raw file):

        "@babel/core": "^7.0.0-rc.1",
        "@babel/preset-env": "^7.0.0-rc.1",
        "babel-loader": "^8.0.0-beta.4",

warning: beta version


admin-dev/themes/default/webpack.config.js, line 82 at r1 (raw file):

      }]
    },
    optimization: {

empty object, is it needed ?

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 31, 2018

Member

We need a rebase here @eternoendless :)

Member

Quetzacoalt91 commented Aug 31, 2018

We need a rebase here @eternoendless :)

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 4, 2018

Member

👋 @eternoendless there are also some comments from @CaptainYouz waiting to be solved.

Sending to QA anyway.

Member

Quetzacoalt91 commented Sep 4, 2018

👋 @eternoendless there are also some comments from @CaptainYouz waiting to be solved.

Sending to QA anyway.

@eternoendless

Reviewable status: 2 of 5 files reviewed, all discussions resolved (waiting on @CaptainYouz)


admin-dev/themes/default/package.json, line 16 at r1 (raw file):

Previously, CaptainYouz (Anas Mammeri) wrote…

warning: beta version

We need babel-loader v8 with webpack 4. They have now released the stable version so i'll upgrade it. Recompiling produces no side effects.


admin-dev/themes/default/webpack.config.js, line 82 at r1 (raw file):

Previously, CaptainYouz (Anas Mammeri) wrote…

empty object, is it needed ?

As discussed, added for simplification. Used below (config.optimization.minimizer).

@CaptainYouz

Reviewable status: 2 of 5 files reviewed, all discussions resolved (waiting on @CaptainYouz)

@marionf marionf self-assigned this Sep 4, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Sep 4, 2018

@marionf marionf removed their assignment Sep 4, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit b9b0301 into PrestaShop:develop Sep 4, 2018

0 of 3 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
code-review/reviewable 3 files left (CaptainYouz)
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 4, 2018

Member

I merged although there are issues with some cs fixer. I'll make a specific PR about this.

Thank you @eternoendless

Member

Quetzacoalt91 commented Sep 4, 2018

I merged although there are issues with some cs fixer. I'll make a specific PR about this.

Thank you @eternoendless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment