New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve extraction of wordings from Smarty templates #52

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@eternoendless
Member

eternoendless commented Oct 22, 2018

  • Automated tests
  • Does not pollute the catalog by skipping wordings in old-style syntax
    (eg: 'mod="mymodule"')
  • Doesn't crash and skip everything when using custom resource
    resolving
Improve extraction of wordings from Smarty templates
- Automated tests
- Does not pollute the catalog by skipping wordings in old-style syntax
  (eg: 'mod="mymodule"')
- Doesn't crash and skip everything when using custom resource
  resolving

@eternoendless eternoendless merged commit 551e24b into PrestaShop:master Nov 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless deleted the eternoendless:fix-smarty-extractor branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment