New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle read Xliff metadata when dumping files #53

merged 3 commits into from Nov 9, 2018


None yet
1 participant

eternoendless commented Nov 9, 2018

When trying to dump a catalog that was read from an Xliff file using XliffFileLoader, the catalog was missing the "original file" metadata, making it impossible to write the same file again due to missing information. This has been fixed in the loader: symfony/symfony#29148.

The catalog's "original file" metadata structure is different when read from an Xliff file and when parsed from source files using TranslationToolsBundle. This Pull Request provides support for the new metadata format as well as improving the <note> information by removing useless information.

eternoendless added some commits Nov 9, 2018

Merge notes metadata read from Xliff with the one generated by the lexer
Also, be less verbose about the file in notes, since that information
is already available in the Xliff file.

@eternoendless eternoendless merged commit 0de5ee1 into PrestaShop:master Nov 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@eternoendless eternoendless deleted the eternoendless:handle-xliff-metadata branch Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment