Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for underscores in the third component of a domain #64

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@eternoendless
Copy link
Member

commented Jul 23, 2019

This part is used in backwards compatibility mode with modules to identify the original file name. Underscores are widely used as file names so we need to support them.

This part is used in backwards compatibility mode with modules to identify the original file name.
Copy link

left a comment

lgtm

@eternoendless

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

Thanks for the review @matthieu-rolland

@eternoendless eternoendless merged commit 8f64364 into PrestaShop:master Aug 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eternoendless eternoendless deleted the eternoendless:support-underscores branch Aug 5, 2019
@@ -88,7 +88,7 @@ public static function buildModuleDomainFromLegacySource($moduleName, $sourceFil
$source = substr($source, 0, -10);
}
$source = ucfirst(strtr($source, ['_' => '']));
$source = ucfirst($source);

This comment has been minimized.

Copy link
@jolelievre

jolelievre Aug 5, 2019

So we keep underscores! Maybe we could camelize?

This comment has been minimized.

Copy link
@eternoendless

eternoendless Aug 5, 2019

Author Member

No, we only keep them for the third part. If we camelized it then it would become a fourth part.

eg.

  • FooBarBar_test => Foo.Bar.Bar_test
  • FooBarBarTest => Foo.Bar.Bar.Test

This comment has been minimized.

Copy link
@jolelievre
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.