From d53704680e326953777a9a9c4e81d04c79bfb0e2 Mon Sep 17 00:00:00 2001 From: matthieu-rolland Date: Wed, 31 Aug 2022 15:29:25 +0200 Subject: [PATCH] remove former ignore instruction --- classes/UpgradeTools/ModuleAdapter.php | 15 --------------- tests/phpstan/phpstan-1.6.1.18.neon | 1 - tests/phpstan/phpstan-1.7.2.5.neon | 1 - tests/phpstan/phpstan-1.7.3.4.neon | 1 - tests/phpstan/phpstan-1.7.4.4.neon | 1 - tests/phpstan/phpstan-1.7.5.1.neon | 1 - tests/phpstan/phpstan-1.7.6.neon | 1 - tests/phpstan/phpstan-1.7.7.neon | 1 - tests/phpstan/phpstan-1.7.8.neon | 1 - tests/phpstan/phpstan-latest.neon | 1 - 10 files changed, 24 deletions(-) diff --git a/classes/UpgradeTools/ModuleAdapter.php b/classes/UpgradeTools/ModuleAdapter.php index 46591df892..99ef95f624 100644 --- a/classes/UpgradeTools/ModuleAdapter.php +++ b/classes/UpgradeTools/ModuleAdapter.php @@ -101,21 +101,6 @@ public function getCommandBus() return $this->commandBus; } - /** - * Available since PrestaShop 8.0 - */ - public function getModuleRepository() - { - if (null === $this->moduleRepository) { - $this->moduleRepository = $this->symfonyAdapter - ->initAppKernel() - ->getContainer() - ->get('prestashop.adapter.module.repository.module_repository'); - } - - return $this->moduleRepository; - } - /** * Upgrade action, disabling all modules not made by PrestaShop. * diff --git a/tests/phpstan/phpstan-1.6.1.18.neon b/tests/phpstan/phpstan-1.6.1.18.neon index fb1b3ab9e2..eaee787c90 100644 --- a/tests/phpstan/phpstan-1.6.1.18.neon +++ b/tests/phpstan/phpstan-1.6.1.18.neon @@ -19,7 +19,6 @@ parameters: - '#Call to method assign\(\) on an unknown class Smarty.#' - '#Call to method fetch\(\) on an unknown class Smarty.#' - '#Call to method getContainer\(\) on an unknown class AppKernel.#' - - '#Function deactivate_custom_modules not found.#' - '#PrestaShop\\PrestaShop\\Adapter\\Module\\ModuleDataUpdater#' - '#Property ModuleCore::\$version \(float\) does not accept string.#' - '#Return typehint of method PrestaShop\\Module\\AutoUpgrade\\UpgradeTools\\ModuleAdapter::getCommandBus\(\) has invalid type PrestaShop\\PrestaShop\\Core\\CommandBus\\TacticianCommandBusAdapter.#' diff --git a/tests/phpstan/phpstan-1.7.2.5.neon b/tests/phpstan/phpstan-1.7.2.5.neon index c89b3643a5..48756f7cbb 100644 --- a/tests/phpstan/phpstan-1.7.2.5.neon +++ b/tests/phpstan/phpstan-1.7.2.5.neon @@ -15,7 +15,6 @@ parameters: - '#Call to method loadClassCache\(\) on an unknown class AppKernel.#' - '#Caught class PrestaShop\\PrestaShop\\Core\\Exception\\CoreException not found.#' - '#Class AppKernel not found.#' - - '#Function deactivate_custom_modules not found.#' - '#Instantiated class AppKernel not found.#' - '#Instantiated class PrestaShop\\PrestaShop\\Core\\Domain\\Theme\\ValueObject\\ThemeName not found.#' - '#PHPDoc tag @var for variable \$commandBus contains unknown class PrestaShop\\PrestaShop\\Core\\CommandBus\\CommandBusInterface.#' diff --git a/tests/phpstan/phpstan-1.7.3.4.neon b/tests/phpstan/phpstan-1.7.3.4.neon index c89b3643a5..48756f7cbb 100644 --- a/tests/phpstan/phpstan-1.7.3.4.neon +++ b/tests/phpstan/phpstan-1.7.3.4.neon @@ -15,7 +15,6 @@ parameters: - '#Call to method loadClassCache\(\) on an unknown class AppKernel.#' - '#Caught class PrestaShop\\PrestaShop\\Core\\Exception\\CoreException not found.#' - '#Class AppKernel not found.#' - - '#Function deactivate_custom_modules not found.#' - '#Instantiated class AppKernel not found.#' - '#Instantiated class PrestaShop\\PrestaShop\\Core\\Domain\\Theme\\ValueObject\\ThemeName not found.#' - '#PHPDoc tag @var for variable \$commandBus contains unknown class PrestaShop\\PrestaShop\\Core\\CommandBus\\CommandBusInterface.#' diff --git a/tests/phpstan/phpstan-1.7.4.4.neon b/tests/phpstan/phpstan-1.7.4.4.neon index aa06b65169..a6af43d6dc 100644 --- a/tests/phpstan/phpstan-1.7.4.4.neon +++ b/tests/phpstan/phpstan-1.7.4.4.neon @@ -11,7 +11,6 @@ parameters: - '#Call to method getMessage\(\) on an unknown class PrestaShop\\PrestaShop\\Core\\Exception\\CoreException.#' - '#Call to method handle\(\) on an unknown class PrestaShop\\PrestaShop\\Core\\CommandBus\\CommandBusInterface.#' - '#Caught class PrestaShop\\PrestaShop\\Core\\Exception\\CoreException not found.#' - - '#Function deactivate_custom_modules not found.#' - '#Instantiated class PrestaShop\\PrestaShop\\Core\\Domain\\Theme\\ValueObject\\ThemeName not found.#' - '#PHPDoc tag @var for variable \$commandBus contains unknown class PrestaShop\\PrestaShop\\Core\\CommandBus\\CommandBusInterface.#' - '#Property ModuleCore::\$version \(float\) does not accept string.#' diff --git a/tests/phpstan/phpstan-1.7.5.1.neon b/tests/phpstan/phpstan-1.7.5.1.neon index f228e2ad0c..315f0a9a44 100644 --- a/tests/phpstan/phpstan-1.7.5.1.neon +++ b/tests/phpstan/phpstan-1.7.5.1.neon @@ -8,6 +8,5 @@ parameters: - '#Access to an undefined property Autoupgrade::\$bootstrap.#' - '#Access to an undefined property Module::\$installed.#' - '#Call to an undefined static method ConfigurationTest::test_memory_limit\(\).#' - - '#Function deactivate_custom_modules not found.#' - '#Instantiated class PrestaShop\\PrestaShop\\Core\\Domain\\Theme\\ValueObject\\ThemeName not found.#' - '#Property ModuleCore::\$version \(float\) does not accept string.#' diff --git a/tests/phpstan/phpstan-1.7.6.neon b/tests/phpstan/phpstan-1.7.6.neon index 45eed3c13f..94c20235ce 100644 --- a/tests/phpstan/phpstan-1.7.6.neon +++ b/tests/phpstan/phpstan-1.7.6.neon @@ -9,7 +9,6 @@ parameters: - '#Access to an undefined property Module::\$installed.#' - '#Call to an undefined static method ConfigurationTest::test_memory_limit\(\).#' - '#Call to method fetchLocale\(\) on an unknown class PrestaShop\\PrestaShop\\Core\\Cldr\\Update.#' - - '#Function deactivate_custom_modules not found.#' - '#Instantiated class PrestaShop\\PrestaShop\\Core\\Cldr\\Update not found.#' - '#Parameter \#1 \$id_hook of method ModuleCore::updatePosition\(\) expects bool, int given.#' - '#Property ModuleCore::\$version \(float\) does not accept string.#' diff --git a/tests/phpstan/phpstan-1.7.7.neon b/tests/phpstan/phpstan-1.7.7.neon index 5aba843bcc..302d07712d 100644 --- a/tests/phpstan/phpstan-1.7.7.neon +++ b/tests/phpstan/phpstan-1.7.7.neon @@ -7,5 +7,4 @@ parameters: ignoreErrors: - '#Access to an undefined property Module::\$installed.#' - '#Call to method fetchLocale\(\) on an unknown class PrestaShop\\PrestaShop\\Core\\Cldr\\Update.#' - - '#Function deactivate_custom_modules not found.#' - '#Instantiated class PrestaShop\\PrestaShop\\Core\\Cldr\\Update not found.#' diff --git a/tests/phpstan/phpstan-1.7.8.neon b/tests/phpstan/phpstan-1.7.8.neon index 94bf1b5eb0..f7fd6891a0 100644 --- a/tests/phpstan/phpstan-1.7.8.neon +++ b/tests/phpstan/phpstan-1.7.8.neon @@ -7,6 +7,5 @@ parameters: ignoreErrors: - '#Access to an undefined property Module::\$installed.#' - '#Call to method fetchLocale\(\) on an unknown class PrestaShop\\PrestaShop\\Core\\Cldr\\Update.#' - - '#Function deactivate_custom_modules not found.#' - '#Instantiated class PrestaShop\\PrestaShop\\Core\\Cldr\\Update not found.#' diff --git a/tests/phpstan/phpstan-latest.neon b/tests/phpstan/phpstan-latest.neon index 5aba843bcc..302d07712d 100644 --- a/tests/phpstan/phpstan-latest.neon +++ b/tests/phpstan/phpstan-latest.neon @@ -7,5 +7,4 @@ parameters: ignoreErrors: - '#Access to an undefined property Module::\$installed.#' - '#Call to method fetchLocale\(\) on an unknown class PrestaShop\\PrestaShop\\Core\\Cldr\\Update.#' - - '#Function deactivate_custom_modules not found.#' - '#Instantiated class PrestaShop\\PrestaShop\\Core\\Cldr\\Update not found.#'