New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignored files outside shop folder #160

Merged
merged 3 commits into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 5, 2018

Fixes #159

When checking the files to ignore during the process, using the temporary folder where release are stored make the results wrong. That was caused by a file path strict check from the filesystem root.


This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 added this to the 4.2.0 milestone Sep 5, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 5, 2018

Member

Upgrade result: 1.7.3 to 1.7.4.2

Upgrade log: tmp.log, no sign of theme/classic

I also made the most visible change on the default theme, to make sure the changes are not overwritten by the upgrade:
capture du 2018-09-05 18-22-47

Member

Quetzacoalt91 commented Sep 5, 2018

Upgrade result: 1.7.3 to 1.7.4.2

Upgrade log: tmp.log, no sign of theme/classic

I also made the most visible change on the default theme, to make sure the changes are not overwritten by the upgrade:
capture du 2018-09-05 18-22-47

@Quetzacoalt91 Quetzacoalt91 merged commit 13bdcd6 into PrestaShop:master Sep 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:ignored-files-incorrect-outside-root branch Sep 6, 2018

@Quetzacoalt91 Quetzacoalt91 restored the Quetzacoalt91:ignored-files-incorrect-outside-root branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment