Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend and optimize autoloader #325

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@Quetzacoalt91
Copy link
Member

commented Jun 27, 2019

Disabling the option prepend-autoloader will allow the PrestaShop autoloader to go first. Although it seems dangerous as the core is unstable during the upgrade, it seems to fix some issues like PrestaShop/PrestaShop#13633

⚠️ Run composer install after applying this PR

@jolelievre
Copy link

left a comment

oohh.. easy ^^
thanks @Quetzacoalt91

@jolelievre

This comment has been minimized.

Copy link

commented Jun 27, 2019

Disabling the option prepend-autoloader will allow the PrestaShop autoloader to go first. Although it seems dangerous as the core is unstable during the upgrade, it seems to fix some issues like PrestaShop/PrestaShop#13633

Anyway didn't we decide that all modules should have prepend false to avoid overriding the core dependencies? (Although I get that upgrade is a more complicated state)

@PierreRambaud PierreRambaud changed the title Prepend and and optimize autoloader Prepend and optimize autoloader Jun 27, 2019

@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2019

Anyway didn't we decide that all modules should have prepend false to avoid overriding the core dependencies? (Although I get that upgrade is a more complicated state)

Exactly! There's also a PR opened on the validator for that matter.

@Quetzacoalt91 Quetzacoalt91 added this to the 4.9.0 milestone Jul 2, 2019

@sarahdib sarahdib added QA approved and removed Waiting for QA labels Jul 3, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit 72d2e1b into PrestaShop:dev Jul 3, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:autoload-changes branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.