Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logs around zip upgrade #327

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@Quetzacoalt91
Copy link
Member

commented Jul 2, 2019

This PR removes the log "Extract using ZipArchive", which is now always true, and add details the path to the zipfile being modified to the logs. This provides additional details to the user about how the module works.

image

@Quetzacoalt91 Quetzacoalt91 added this to the 4.9.0 milestone Jul 2, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

QA needed?

@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

Thanks for review

@Quetzacoalt91 Quetzacoalt91 merged commit 10461af into PrestaShop:dev Jul 3, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:logs-zips-modules branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.