New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid files to be generated outside the admin folder #83

Merged
merged 3 commits into from Jun 22, 2018

Conversation

Projects
None yet
1 participant
@Quetzacoalt91
Member

Quetzacoalt91 commented Jun 20, 2018

In the previous versions, the files has to be ALWAYS generated in the admin folder.

With the refacto, it appeared they could be found in the module folder, for instance when you call the file cli-upgrade.php.
This PR

  • fixes the definition of PS_ADMIN_DIR
  • refactoed (again) the init file
  • fixes the --dir option in the Readme
  • Adds carriage returns in the log

@Quetzacoalt91 Quetzacoalt91 added this to the 4.0.0 milestone Jun 21, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit f17a9ab into PrestaShop:dev Jun 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:cli-init branch Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment